Bug 107282 - Web Inspector: change HeapSnapshotLoader to allow loading native heap snapshots
Summary: Web Inspector: change HeapSnapshotLoader to allow loading native heap snapshots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 107254
  Show dependency tree / graph
 
Reported: 2013-01-18 07:37 PST by Yury Semikhatsky
Modified: 2013-01-20 23:52 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.77 KB, patch)
2013-01-18 07:41 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-01-18 07:37:09 PST 
HeapSnapshotLoader currently always creates JSHeapSnapshot but the snapshot type can be passed as parameter to support native heap snapshots.
Comment 1 Yury Semikhatsky 2013-01-18 07:41:21 PST 
Created attachment 183455 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-01-18 08:06:09 PST 
Comment on attachment 183455 [details]
Patch

lgtm
Comment 3 WebKit Review Bot 2013-01-20 23:52:19 PST 
Comment on attachment 183455 [details]
Patch

Clearing flags on attachment: 183455

Committed r140306: <http://trac.webkit.org/changeset/140306>
Comment 4 WebKit Review Bot 2013-01-20 23:52:23 PST 
All reviewed patches have been landed.  Closing bug.