Bug 107266 - [chromium] move speech related methods to TestRunner library
Summary: [chromium] move speech related methods to TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 91308
  Show dependency treegraph
 
Reported: 2013-01-18 05:42 PST by jochen
Modified: 2013-01-20 12:17 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.79 KB, patch)
2013-01-20 03:42 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (14.95 KB, patch)
2013-01-20 11:20 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-18 05:42:16 PST
Move

    void addMockSpeechInputResult(const CppArgumentList&, CppVariant*);
    void setMockSpeechInputDumpRect(const CppArgumentList&, CppVariant*);
    void addMockSpeechRecognitionResult(const CppArgumentList&, CppVariant*);
    void setMockSpeechRecognitionError(const CppArgumentList&, CppVariant*);
    void wasMockSpeechRecognitionAborted(const CppArgumentList&, CppVariant*);
Comment 1 jochen 2013-01-20 03:42:12 PST
Created attachment 183663 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-20 03:43:47 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2013-01-20 09:54:19 PST
Comment on attachment 183663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183663&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:110
> +#if ENABLE(INPUT_SPEECH)

We don't usually put ENABLE macros in public header files.  The consumers of these headers on the Chromium side won't know what features are enabled.
Comment 4 jochen 2013-01-20 11:20:22 PST
Created attachment 183678 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-01-20 12:17:52 PST
Comment on attachment 183678 [details]
Patch for landing

Clearing flags on attachment: 183678

Committed r140277: <http://trac.webkit.org/changeset/140277>
Comment 6 WebKit Review Bot 2013-01-20 12:17:56 PST
All reviewed patches have been landed.  Closing bug.