Bug 107255 – Add explicit keyword to constructors in platform-specific InspectorClient

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Seokju Kwon]

Add explicit keyword to constructors that take exactly one argument
in platform-specific implementation of InspectorClient.

[Seokju Kwon]

Created attachment 183424 [details]
Patch

[WebKit Review Bot]

Attachment 183424 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1
Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h:37:  The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:51:  The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 183424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183424&action=review

LGMT with nits.

>> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:51
>> +        explicit InspectorClient(WebKitWebView* webView);
> 
> The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]

Nit: Remove it.

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:62
> +    explicit WebInspectorClient(WebView *);

Nit: WebView * => WebView*

>> Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h:37
>> +    explicit InspectorClientWinCE(WebView* webView);
> 
> The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]

Nit: Remove it.

[Seokju Kwon]

Created attachment 183446 [details]
Patch

[Seokju Kwon]

Comment on attachment 183446 [details]
Patch

Fix some coding style issues

Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h:37:  The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:51:  The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:79:  The parameter name "webInspector" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:79:  The parameter name "inspectorClient" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:96:  The parameter name "height" adds no information, so it should be removed.  [readability/parameter_name] [5]

[WebKit Review Bot]

Comment on attachment 183446 [details]
Patch

Clearing flags on attachment: 183446

Committed r140148: <http://trac.webkit.org/changeset/140148>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.