Bug 107251 – [mac] DRT and WKTR should disable NSBeep

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tim Horton]

We can't test NSBeep, and we don't, and it's annoying when running layout tests locally, so we should turn it off!

[Tim Horton]

Created attachment 183418 [details]
meh patch

[Simon Fraser (smfr)]

I don't think we're trying to test NSBeep. I think we get NSBeep when some actions are not handled, no? I thought we overrode some NSResponder methods in a few places to avoid beeping.

[Tim Horton]

(In reply to comment #2)
> I don't think we're trying to test NSBeep.

I was joking poorly.

> I think we get NSBeep when some actions are not handled, no? I thought we overrode some NSResponder methods in a few places to avoid beeping.

But we also call it ourselves in a bunch of places (see WebCore::systemBeep())! Those aren't prevented.

[Tim Horton]

http://trac.webkit.org/changeset/140188

[Alexey Proskuryakov]

FWIW, we use a different technique to shut up plug-ins when snapshotting, and it doesn't involve SPIs:


static void muteAudio(void)
{
    AudioObjectPropertyAddress propertyAddress = { kAudioHardwarePropertyProcessIsAudible, kAudioObjectPropertyScopeGlobal, kAudioObjectPropertyElementMaster };
    UInt32 propertyData = 0;
    OSStatus result = AudioObjectSetPropertyData(kAudioObjectSystemObject, &propertyAddress, 0, 0, sizeof(UInt32), &propertyData);
    ASSERT_UNUSED(result, result == noErr);
}

[Tim Horton]

This... didn't work. It covered some cases, but not all of them. Maybe I should do Alexey's thing instead.

[Darin Adler]

Cleared the review flag so this doesn’t show up as “reviewed but not landed”.

[Alexey Proskuryakov]

I didn't realize that this bug was still open, so I fixed the remaining case in bug 120652 (at least some of them, but hopefully all that remained).

We probably don't want to disable all audio, as we need to test WebAudio.