Bug 107245 - [V8] Remove custom V8ScriptProfileNodeCustom::toV8()
Summary: [V8] Remove custom V8ScriptProfileNodeCustom::toV8()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 02:08 PST by Kentaro Hara
Modified: 2013-01-18 11:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.74 KB, patch)
2013-01-18 02:10 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-18 02:08:39 PST
V8ScriptProfileNodeCustom::toV8() needs not to be custom. Furthermore, the current custom toV8() is wrong in that it doesn't use a creationContext and it doesn't set a wrapper class id. This is one of steps to avoiding ASSERT()s that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 .
Comment 1 Kentaro Hara 2013-01-18 02:10:16 PST
Created attachment 183409 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-18 11:15:59 PST
Comment on attachment 183409 [details]
Patch

Clearing flags on attachment: 183409

Committed r140185: <http://trac.webkit.org/changeset/140185>
Comment 3 WebKit Review Bot 2013-01-18 11:16:04 PST
All reviewed patches have been landed.  Closing bug.