Bug 107237 – REGRESSION(r140101): caused debug asserts in fast/forms/associated-element-crash.html and html5lib/run-template.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/140101 broke the build:
caused debug asserts in fast/forms/associated-element-crash.html and html5lib/run-template.html (Requested by dominicc on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 183395 [details]
ROLLOUT of r140101

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Eric Seidel (no email)]

Could you document the ASSERTS here, so the author has an easier time fixing?

[Eric Seidel (no email)]

Thank you, btw.

[Dominic Cooney]

I added Chromium debug crash expectations in r140108.

Here is the assert; this one from html5lib/run-template.html on Mac 10.7 dbg:

STDOUT: <empty>
STDERR: ASSERTION FAILED: document() == newChild->document()
STDERR: ../../third_party/WebKit/Source/WebCore/dom/ContainerNode.cpp(699) : void WebCore::ContainerNode::parserAppendChild(PassRefPtr<WebCore::Node>)
STDERR: 1   0x5fd337a WebCore::ContainerNode::parserAppendChild(WTF::PassRefPtr<WebCore::Node>)
STDERR: 2   0x64454ff _ZN7WebCoreL11executeTaskERNS_24HTMLConstructionSiteTaskE
STDERR: 3   0x644537b WebCore::HTMLConstructionSite::executeQueuedTasks()
STDERR: 4   0x6483a6c WebCore::HTMLTreeBuilder::constructTree(WebCore::AtomicHTMLToken*)
STDERR: 5   0x6450bc0 WebCore::HTMLDocumentParser::constructTreeFromHTMLToken(WebCore::HTMLToken&)
STDERR: 6   0x64502c1 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode)
STDERR: 7   0x644fb7f WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode)
STDERR: 8   0x6450dee WebCore::HTMLDocumentParser::insert(WebCore::SegmentedString const&)
STDERR: 9   0x6005152 WebCore::Document::write(WebCore::SegmentedString const&, WebCore::Document*)
STDERR: 10  0x6005202 WebCore::Document::write(WTF::String const&, WebCore::Document*)
STDERR: 11  0x7a39ec0 WebCore::V8HTMLDocument::writeCallback(v8::Arguments const&)
STDERR: 12  0x2e6f06e7
STDERR: Received signal 11 SEGV_MAPERR 0000bbadbeef

[Rafael Weinstein]

Created attachment 183516 [details]
Patch

[Rafael Weinstein]

Note that 140101 wasn't ever rolled out.

This patch fixes the template crash, and removes the TestExpectations for the crashes

Also, note that fast/forms/associated-element-crash.html doesn't correctly name a layout test. I assume this was a meant to be fast/forms/form-associated-element-crash.html, but since it isn't crashing on the bots and I couldn't repro locally, and thus the crash was a flake.

[Rafael Weinstein]

ping.

[WebKit Review Bot]

Comment on attachment 183516 [details]
Patch

Rejecting attachment 183516 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
 1 with fuzz 3.
patching file Source/WebCore/html/parser/HTMLConstructionSite.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/TestExpectations
Hunk #1 FAILED at 4313.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16035881

[Dominic Cooney]

Committed r140537.

[Radar WebKit Bug Importer]

<rdar://problem/13870264>