Bug 107222 - [Shadow DOM] Specifying scrollbar style of an element having RenderLayer in ShadowDOM does not work.
Summary: [Shadow DOM] Specifying scrollbar style of an element having RenderLayer in S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Web Components Team
URL:
Keywords:
Depends on:
Blocks: 91821
  Show dependency tree / graph
 
Reported: 2013-01-17 21:47 PST by Shinya Kawanaka
Modified: 2013-01-20 18:26 PST (History)
10 users (show)

See Also:

Attachments
Patch (7.22 KB, patch)
2013-01-17 22:26 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2013-01-17 23:16 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch for landing (6.27 KB, patch)
2013-01-20 17:54 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2013-01-17 21:47:14 PST 
scrollbar style for host is applied instead.

The reason is RenderLayer uses shadowAncestorNode() anytime.
Maybe we have to check ShadowRoot->type()?
Comment 1 Shinya Kawanaka 2013-01-17 22:26:12 PST 
Created attachment 183377 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-17 22:29:10 PST 
Comment on attachment 183377 [details]
Patch

Attachment 183377 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15939473
Comment 3 Build Bot 2013-01-17 22:30:54 PST 
Comment on attachment 183377 [details]
Patch

Attachment 183377 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15947283
Comment 4 Build Bot 2013-01-17 22:31:32 PST 
Comment on attachment 183377 [details]
Patch

Attachment 183377 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15925965
Comment 5 Peter Beverloo (cr-android ews) 2013-01-17 22:33:59 PST 
Comment on attachment 183377 [details]
Patch

Attachment 183377 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15955051
Comment 6 Early Warning System Bot 2013-01-17 22:43:04 PST 
Comment on attachment 183377 [details]
Patch

Attachment 183377 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15940511
Comment 7 Early Warning System Bot 2013-01-17 22:49:43 PST 
Comment on attachment 183377 [details]
Patch

Attachment 183377 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15937556
Comment 8 Shinya Kawanaka 2013-01-17 23:15:19 PST 
Oops I forgot to remove debug code...
Comment 9 Shinya Kawanaka 2013-01-17 23:16:01 PST 
Created attachment 183384 [details]
Patch
Comment 10 Simon Fraser (smfr) 2013-01-18 08:53:29 PST 
Comment on attachment 183384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183384&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2698
> +static inline RenderObject* actualRendererForScrollbar(RenderObject* renderer)

I think you could just call this rendererForScrollbar()
Comment 11 Shinya Kawanaka 2013-01-20 17:49:36 PST 
(In reply to comment #10)
> (From update of attachment 183384 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183384&action=review
> 
> > Source/WebCore/rendering/RenderLayer.cpp:2698
> > +static inline RenderObject* actualRendererForScrollbar(RenderObject* renderer)
> 
> I think you could just call this rendererForScrollbar()

Thanks. I'll update the patch and land it.
Comment 12 Shinya Kawanaka 2013-01-20 17:54:23 PST 
Created attachment 183693 [details]
Patch for landing
Comment 13 WebKit Review Bot 2013-01-20 18:26:15 PST 
Comment on attachment 183693 [details]
Patch for landing

Clearing flags on attachment: 183693

Committed r140287: <http://trac.webkit.org/changeset/140287>
Comment 14 WebKit Review Bot 2013-01-20 18:26:20 PST 
All reviewed patches have been landed.  Closing bug.