Bug 107213 – Allow fixed background layers to be moved by the ScrollingCoordinator

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Allow fixed background layers to be moved by the ScrollingCoordinator

[Simon Fraser (smfr)]

Created attachment 183345 [details]
Patch

[Build Bot]

Comment on attachment 183345 [details]
Patch

Attachment 183345 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15938424

New failing tests:
fast/parser/append-child-followed-by-document-write.html

[Build Bot]

Comment on attachment 183345 [details]
Patch

Attachment 183345 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15938492

New failing tests:
platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html
fast/parser/append-child-followed-by-document-write.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background.html
platform/mac/tiled-drawing/fixed-background/fixed-html-background.html

[WebKit Review Bot]

Comment on attachment 183345 [details]
Patch

Attachment 183345 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15944426

New failing tests:
fast/parser/append-child-followed-by-document-write.html

[WebKit Review Bot]

Comment on attachment 183345 [details]
Patch

Attachment 183345 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15955111

New failing tests:
fast/parser/append-child-followed-by-document-write.html

[James Robinson]

Not really a fan of the concept of a 'counter-scrolling' layer - can't we set this up the same was as position:fixed elements?  We'll have to have special logic for both of these for the overscroll bounce effect.

[Simon Fraser (smfr)]

The problem with having it like a position:fixed layer is that it then needs special code to insert it in the hierarchy (since it will not be grouped with the other GraphicsLayers owned by the same RenderLayerBacking), and making it work with zooming was really tricky. The counter-scrolling solution came out easier.

[Simon Fraser (smfr)]

Created attachment 183564 [details]
Patch

[Tim Horton]

Comment on attachment 183564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183564&action=review

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:120
> +    void setCounterScrollingLayerDidChange(bool layerDidChange) { m_counterScrollingLayerDidChange = layerDidChange; } // FIXME: Need this?

Well, do you?

> Source/WebCore/page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:2
> + * Copyright (C) 2012 Apple Inc. All rights reserved.

Nope.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1251
> +        else  {
> +            if (FrameView* frameView = view()->frameView())
> +                viewportRect.setLocation(IntPoint(frameView->scrollOffsetForFixedPosition()));
> +        }

Is this actually our style? I'm not positive.

[Simon Fraser (smfr)]

Created attachment 183566 [details]
Patch

[WebKit Review Bot]

Attachment 183566 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 183564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183564&action=review

> Source/WebCore/ChangeLog:9
> +        fixed root backgounds (those which have background images all of which have

s/backgounds/backgrounds/

[Tim Horton]

Comment on attachment 183566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183566&action=review

> Source/WebCore/ChangeLog:24
> +        (WebCore::ScrollingCoordinator::updateMainFrameScrollPosition): Sync or set the postion of the

s/postion/position/

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/140223