Bug 107201 - BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark
Summary: BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-01-17 16:40 PST by Adam Barth
Modified: 2013-01-17 18:24 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.92 KB, patch)
2013-01-17 16:44 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (3.01 KB, patch)
2013-01-17 17:06 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-01-17 16:40:54 PST
BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark
Comment 1 Adam Barth 2013-01-17 16:44:32 PST
Created attachment 183315 [details]
Patch
Comment 2 Tony Gentilcore 2013-01-17 16:58:41 PST
Comment on attachment 183315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183315&action=review

> Source/WebCore/html/parser/BackgroundHTMLParser.cpp:50
> +static const size_t pendingTokenLimit = 4000;

This constant seems so arbitrary. Did you try running with other values? I'd also recommend a comment explaining how it was chosen (or else a FIXME).
Comment 3 Adam Barth 2013-01-17 17:04:41 PST
(In reply to comment #2)
> (From update of attachment 183315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183315&action=review
> 
> > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:50
> > +static const size_t pendingTokenLimit = 4000;
> 
> This constant seems so arbitrary. Did you try running with other values? I'd also recommend a comment explaining how it was chosen (or else a FIXME).

I just grabbed the constant from Eric's patch.  I'd be happy to add a FIXME saying that it's arbitrary and needs to be tuned.
Comment 4 Adam Barth 2013-01-17 17:06:56 PST
Created attachment 183323 [details]
Patch
Comment 5 WebKit Review Bot 2013-01-17 18:02:18 PST
Comment on attachment 183323 [details]
Patch

Clearing flags on attachment: 183323

Committed r140079: <http://trac.webkit.org/changeset/140079>
Comment 6 WebKit Review Bot 2013-01-17 18:02:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2013-01-17 18:24:18 PST
Thanks!