<rdar://problem/12849029> Using minimum layout width auto-sizing currently doesn't shrink past the current viewport size, so it can only get *taller*, never shorter. FrameView::enableAutoSizeMode already fiddles with layout to fix this, so we should make use of it!
Created attachment 183316 [details] patch
Hmm, I should probably support falling back out of auto-sizing mode.
Created attachment 183319 [details] patch with a const and WebPage will disable the mode if needed
Comment on attachment 183319 [details] patch with a const and WebPage will disable the mode if needed View in context: https://bugs.webkit.org/attachment.cgi?id=183319&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3787 > + if (!m_minimumLayoutWidth) > + corePage()->mainFrame()->view()->enableAutoSizeMode(false, IntSize(), IntSize()); It's weird that you disable auto size mode here, but enable it in the drawing area. I think this should be fixed; this mode should be indpendent of what kind of drawing area is being used.
Created attachment 183341 [details] patch
Comment on attachment 183341 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=183341&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3789 > + m_minimumLayoutWidth = minimumLayoutWidth; > + > + if (minimumLayoutWidth > 0) > + corePage()->mainFrame()->view()->enableAutoSizeMode(true, IntSize(minimumLayoutWidth, 1), IntSize(minimumLayoutWidth, INT_MAX)); > + else > + corePage()->mainFrame()->view()->enableAutoSizeMode(false, IntSize(), IntSize()); Do we have to call enableAutoSizeMode() even when m_minimumLayoutWidth doesn't change? > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:-375 > - if (m_minimumLayoutWidth > 0) { > - m_webPage->setSize(IntSize(m_minimumLayoutWidth, 0)); > - m_webPage->layoutIfNeeded(); > + if (!m_webPage->minimumLayoutWidth()) > + m_webPage->setSize(size); > + > + m_webPage->layoutIfNeeded(); > > + if (m_webPage->minimumLayoutWidth()) { > contentSize = m_webPage->mainWebFrame()->contentBounds().size(); > size = contentSize; > } > > - m_webPage->setSize(size); > - m_webPage->layoutIfNeeded(); This is pretty confusing. I don't know whose responsibility it is to set the size of the WebPage.
http://trac.webkit.org/changeset/140087
Aahhhh, all the random assertion failures. I'm investigating.
(In reply to comment #8) > Aahhhh, all the random assertion failures. I'm investigating. I can reproduce with this rolled out, must be something else.