WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107196
Coordinated Graphics: CoordinatedTile::updateBackBuffer() returns dirty rects.
https://bugs.webkit.org/show_bug.cgi?id=107196
Summary
Coordinated Graphics: CoordinatedTile::updateBackBuffer() returns dirty rects.
Dongseong Hwang
Reported
2013-01-17 16:09:00 PST
Currently, CoordinatedTile::updateBackBuffer() always returns an empty vector. This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects.
Attachments
Patch
(1.68 KB, patch)
2013-01-17 16:10 PST
,
Dongseong Hwang
kenneth
: review+
Details
Formatted Diff
Diff
Patch for land
(1.71 KB, patch)
2013-01-18 02:26 PST
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2013-01-17 16:10:12 PST
Created
attachment 183304
[details]
Patch
Kenneth Rohde Christiansen
Comment 2
2013-01-18 01:45:41 PST
Comment on
attachment 183304
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=183304&action=review
> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103 > + Vector<IntRect> updatedRects; > + updatedRects.append(m_dirtyRect); > m_dirtyRect = IntRect(); > - return Vector<IntRect>(); > + return updatedRects;
Why are we returning a vector? isnt m_dirtyRect not just one rect?
Dongseong Hwang
Comment 3
2013-01-18 01:53:05 PST
Comment on
attachment 183304
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=183304&action=review
>> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103 >> + return updatedRects; > > Why are we returning a vector? isnt m_dirtyRect not just one rect?
CoordinatedTile::updateBackBuffer() overrides Tile::updateBackBuffer(), and Tile::updateBackBuffer() returns vector. We can refactor it later :)
Kenneth Rohde Christiansen
Comment 4
2013-01-18 02:14:07 PST
Comment on
attachment 183304
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=183304&action=review
> Source/WebKit2/ChangeLog:9 > + This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects.
rect* - you could refrase
Dongseong Hwang
Comment 5
2013-01-18 02:26:45 PST
Created
attachment 183412
[details]
Patch for land
WebKit Review Bot
Comment 6
2013-01-18 03:30:44 PST
Comment on
attachment 183412
[details]
Patch for land Clearing flags on attachment: 183412 Committed
r140118
: <
http://trac.webkit.org/changeset/140118
>
WebKit Review Bot
Comment 7
2013-01-18 03:30:48 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug