Bug 107196 - Coordinated Graphics: CoordinatedTile::updateBackBuffer() returns dirty rects.
Summary: Coordinated Graphics: CoordinatedTile::updateBackBuffer() returns dirty rects.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks: 105787
  Show dependency tree / graph
 
Reported: 2013-01-17 16:09 PST by Dongseong Hwang
Modified: 2013-01-18 03:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2013-01-17 16:10 PST, Dongseong Hwang 		kenneth: review+
Details | Formatted Diff | Diff
Patch for land (1.71 KB, patch)
2013-01-18 02:26 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-01-17 16:09:00 PST 
Currently, CoordinatedTile::updateBackBuffer() always returns an empty vector.
This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects.
Comment 1 Dongseong Hwang 2013-01-17 16:10:12 PST 
Created attachment 183304 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2013-01-18 01:45:41 PST 
Comment on attachment 183304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103
> +    Vector<IntRect> updatedRects;
> +    updatedRects.append(m_dirtyRect);
>      m_dirtyRect = IntRect();
> -    return Vector<IntRect>();
> +    return updatedRects;

Why are we returning a vector? isnt m_dirtyRect not just one rect?
Comment 3 Dongseong Hwang 2013-01-18 01:53:05 PST 
Comment on attachment 183304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review

>> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103
>> +    return updatedRects;
> 
> Why are we returning a vector? isnt m_dirtyRect not just one rect?

CoordinatedTile::updateBackBuffer() overrides Tile::updateBackBuffer(), and Tile::updateBackBuffer() returns vector.
We can refactor it later :)
Comment 4 Kenneth Rohde Christiansen 2013-01-18 02:14:07 PST 
Comment on attachment 183304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review

> Source/WebKit2/ChangeLog:9
> +        This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects.

rect* - you could refrase
Comment 5 Dongseong Hwang 2013-01-18 02:26:45 PST 
Created attachment 183412 [details]
Patch for land
Comment 6 WebKit Review Bot 2013-01-18 03:30:44 PST 
Comment on attachment 183412 [details]
Patch for land

Clearing flags on attachment: 183412

Committed r140118: <http://trac.webkit.org/changeset/140118>
Comment 7 WebKit Review Bot 2013-01-18 03:30:48 PST 
All reviewed patches have been landed.  Closing bug.