Currently, CoordinatedTile::updateBackBuffer() always returns an empty vector. This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects.
Created attachment 183304 [details] Patch
Comment on attachment 183304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103 > + Vector<IntRect> updatedRects; > + updatedRects.append(m_dirtyRect); > m_dirtyRect = IntRect(); > - return Vector<IntRect>(); > + return updatedRects; Why are we returning a vector? isnt m_dirtyRect not just one rect?
Comment on attachment 183304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:103 >> + return updatedRects; > > Why are we returning a vector? isnt m_dirtyRect not just one rect? CoordinatedTile::updateBackBuffer() overrides Tile::updateBackBuffer(), and Tile::updateBackBuffer() returns vector. We can refactor it later :)
Comment on attachment 183304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183304&action=review > Source/WebKit2/ChangeLog:9 > + This patch makes CoordinatedTile::updateBackBuffer() return correct dirty rects. rect* - you could refrase
Created attachment 183412 [details] Patch for land
Comment on attachment 183412 [details] Patch for land Clearing flags on attachment: 183412 Committed r140118: <http://trac.webkit.org/changeset/140118>
All reviewed patches have been landed. Closing bug.