Bug 107177 - Make it possible for the root background to be painted into its own GraphicsLayer
Summary: Make it possible for the root background to be painted into its own GraphicsL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-17 14:08 PST by Simon Fraser (smfr)
Modified: 2013-01-17 16:50 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.23 MB, patch)
2013-01-17 14:29 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Fix build errors (1.23 MB, patch)
2013-01-17 15:17 PST, Simon Fraser (smfr)
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-01-17 14:08:22 PST
We plan to paint the root background into its own GraphicsLayer, which we can leave unscrolled as the page scrolls, to avoid painting.
Comment 1 Simon Fraser (smfr) 2013-01-17 14:29:25 PST
Created attachment 183278 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-17 14:32:47 PST
Attachment 183278 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-01-17 14:37:46 PST
Comment on attachment 183278 [details]
Patch

Attachment 183278 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15945123
Comment 4 Dave Hyatt 2013-01-17 14:43:25 PST
Comment on attachment 183278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183278&action=review

r=me, fix the style issues.

> Source/WebCore/rendering/RenderObject.h:547
> +    bool hasEntirelyFixedBackground() const;

I'd just inline this like the method above it.
Comment 5 Simon Fraser (smfr) 2013-01-17 15:17:16 PST
Created attachment 183295 [details]
Fix build errors
Comment 6 Simon Fraser (smfr) 2013-01-17 15:17:50 PST
Comment on attachment 183295 [details]
Fix build errors

Moving hyatt's r+ forward
Comment 7 WebKit Review Bot 2013-01-17 15:21:12 PST
Attachment 183295 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Simon Fraser (smfr) 2013-01-17 16:12:56 PST
http://trac.webkit.org/changeset/140068
Comment 9 Hin-Chung Lam 2013-01-17 16:50:06 PST
The crash happens on one of our bots:

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/4237/steps/webkit_tests/logs/stdio
Comment 10 Hin-Chung Lam 2013-01-17 16:50:44 PST
Please look for svg/wicd/test-scalable-background-image2.xhtml in the log.