Bug 107177 – Make it possible for the root background to be painted into its own GraphicsLayer

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

We plan to paint the root background into its own GraphicsLayer, which we can leave unscrolled as the page scrolls, to avoid painting.

[Simon Fraser (smfr)]

Created attachment 183278 [details]
Patch

[WebKit Review Bot]

Attachment 183278 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 183278 [details]
Patch

Attachment 183278 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15945123

[Dave Hyatt]

Comment on attachment 183278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183278&action=review

r=me, fix the style issues.

> Source/WebCore/rendering/RenderObject.h:547
> +    bool hasEntirelyFixedBackground() const;

I'd just inline this like the method above it.

[Simon Fraser (smfr)]

Created attachment 183295 [details]
Fix build errors

[Simon Fraser (smfr)]

Comment on attachment 183295 [details]
Fix build errors

Moving hyatt's r+ forward

[WebKit Review Bot]

Attachment 183295 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/140068

[Hin-Chung Lam]

The crash happens on one of our bots:

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/4237/steps/webkit_tests/logs/stdio

[Hin-Chung Lam]

Please look for svg/wicd/test-scalable-background-image2.xhtml in the log.