Bug 107169 - [BlackBerry] Check if continuous spellchecking is enabled before processing a request
Summary: [BlackBerry] Check if continuous spellchecking is enabled before processing a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-17 13:33 PST by Nima Ghanavatian
Modified: 2013-01-18 09:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2013-01-18 07:29 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2013-01-18 08:05 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-01-17 13:33:32 PST 
SSIA
Comment 1 Nima Ghanavatian 2013-01-18 07:29:32 PST 
Created attachment 183451 [details]
Patch
Comment 2 Rob Buis 2013-01-18 07:33:37 PST 
Comment on attachment 183451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183451&action=review

Ok, but please remove isSpellChecked before landing.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:224
> +    bool isSpellCheckEnabled();

Should not be part of this patch.
Comment 3 Nima Ghanavatian 2013-01-18 08:05:46 PST 
Created attachment 183462 [details]
Patch
Comment 4 Rob Buis 2013-01-18 08:54:03 PST 
Comment on attachment 183462 [details]
Patch

Even better!
Comment 5 WebKit Review Bot 2013-01-18 09:15:30 PST 
Comment on attachment 183462 [details]
Patch

Clearing flags on attachment: 183462

Committed r140161: <http://trac.webkit.org/changeset/140161>
Comment 6 WebKit Review Bot 2013-01-18 09:15:33 PST 
All reviewed patches have been landed.  Closing bug.