Bug 107159 - Stop the background parser when canceling parsing to avoid crashing on many layout tests
Summary: Stop the background parser when canceling parsing to avoid crashing on many l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-01-17 12:32 PST by Eric Seidel (no email)
Modified: 2013-01-17 14:54 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2013-01-17 12:33 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (1.42 KB, patch)
2013-01-17 13:06 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-01-17 12:32:19 PST
Stop the background parser when canceling parsing to avoid crashing on many layout tests:w
Comment 1 Eric Seidel (no email) 2013-01-17 12:33:20 PST
Created attachment 183246 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-17 12:59:57 PST
Comment on attachment 183246 [details]
Patch

Rejecting attachment 183246 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
o-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp -o obj/Source/WebCore/html/parser/webcore_html.HTMLDocumentParser.o
../../Source/WebCore/html/parser/HTMLDocumentParser.cpp: In member function 'virtual void WebCore::HTMLDocumentParser::stopParsing()':
../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:134: error: 'stopBackgroundParser' was not declared in this scope
ninja: build stopped: subcommand failed.

Full output: http://queues.webkit.org/results/15943107
Comment 3 Eric Seidel (no email) 2013-01-17 13:00:20 PST
I guess the rest hasnt' been upstreamed yet?
Comment 4 Eric Seidel (no email) 2013-01-17 13:01:44 PST
Oh, this needs enable wraps.
Comment 5 Eric Seidel (no email) 2013-01-17 13:06:16 PST
Created attachment 183251 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-01-17 14:54:17 PST
Comment on attachment 183251 [details]
Patch for landing

Clearing flags on attachment: 183251

Committed r140050: <http://trac.webkit.org/changeset/140050>
Comment 7 WebKit Review Bot 2013-01-17 14:54:20 PST
All reviewed patches have been landed.  Closing bug.