Bug 107151 - MathML padding overrides only need to be on RenderMathMLRoot
Summary: MathML padding overrides only need to be on RenderMathMLRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-17 12:01 PST by Ojan Vafai
Modified: 2013-01-17 12:57 PST (History)
10 users (show)

See Also:

Attachments
Patch (11.55 KB, patch)
2013-01-17 12:03 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-01-17 12:01:47 PST 
MathML padding overrides only need to be on RenderMathMLRoot
Comment 1 Ojan Vafai 2013-01-17 12:03:08 PST 
Created attachment 183238 [details]
Patch
Comment 2 Dave Barton 2013-01-17 12:53:24 PST 
Actually this whole mechanism (intrinsic padding for MathML) could be removed now, using flexbox's order property instead of absolute positioning, to get <mroot>'s 2nd child (the index) to be placed before the first child (the base, i.e. radicand). (Note this technique also fixes a major limitation of http://www.w3.org/TR/mathml-for-css/#d2e165 for other browser engines.)

I recommend this - I know the guys who implemented flexbox in webkit and they're really smart. :)
Comment 3 WebKit Review Bot 2013-01-17 12:57:24 PST 
Comment on attachment 183238 [details]
Patch

Clearing flags on attachment: 183238

Committed r140032: <http://trac.webkit.org/changeset/140032>
Comment 4 WebKit Review Bot 2013-01-17 12:57:28 PST 
All reviewed patches have been landed.  Closing bug.