Bug 107145 - [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
Summary: [Chromium] Update some #includes in DumpRenderTree for headers in the new Pla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2013-01-17 11:09 PST by Mark Pilgrim (Google)
Modified: 2013-01-23 11:57 PST (History)
8 users (show)

See Also:

Attachments
Patch (24.32 KB, patch)
2013-01-17 11:09 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (29.40 KB, patch)
2013-01-17 11:28 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (20.91 KB, patch)
2013-01-23 09:13 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2013-01-17 11:09:20 PST 
[Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
Comment 1 Mark Pilgrim (Google) 2013-01-17 11:09:58 PST 
Created attachment 183219 [details]
Patch
Comment 2 Kentaro Hara 2013-01-17 11:13:07 PST 
Comment on attachment 183219 [details]
Patch

ok
Comment 3 WebKit Review Bot 2013-01-17 11:13:29 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Kentaro Hara 2013-01-17 11:19:37 PST 
Comment on attachment 183219 [details]
Patch

sorry, this requires review from API reviewers.

pilgrim: would you set r? again?
Comment 5 Tony Chang 2013-01-17 11:23:55 PST 
Comment on attachment 183219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183219&action=review

> Tools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp:40
> +#include <public/WebCString.h>

It's strange to me that 'public' is in the include path.  Shouldn't it just be WebCString.h and have Source/Platform/chromium/public in the include path?  I'm not sure why Source/Platform/chromium is in the include path.
Comment 6 jochen 2013-01-17 11:24:19 PST 
Comment on attachment 183219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183219&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:34
> +#include <public/WebSettings.h>

The headers in TestRunner/public need to specify the full path relative to Source/
Comment 7 Mark Pilgrim (Google) 2013-01-17 11:28:45 PST 
Created attachment 183230 [details]
Patch
Comment 8 Mark Pilgrim (Google) 2013-01-17 11:29:33 PST 
Comment on attachment 183230 [details]
Patch

Reverted changes in chromium/TestRunner/public/
Comment 9 jochen 2013-01-17 12:00:05 PST 
ChangeLog for Source/WebKit/chromium is missing?
Comment 10 Mark Pilgrim (Google) 2013-01-23 09:13:27 PST 
Created attachment 184250 [details]
Patch
Comment 11 Mark Pilgrim (Google) 2013-01-23 09:14:02 PST 
Comment on attachment 184250 [details]
Patch

Removed spurious files outside Tools/DumpRenderTree from previous patch.
Comment 12 WebKit Review Bot 2013-01-23 11:57:05 PST 
Comment on attachment 184250 [details]
Patch

Clearing flags on attachment: 184250

Committed r140565: <http://trac.webkit.org/changeset/140565>
Comment 13 WebKit Review Bot 2013-01-23 11:57:10 PST 
All reviewed patches have been landed.  Closing bug.