Bug 107127 - Web Inspector: InstrumentingAgents should be registered in InspectorInstrumentation only when there is a front-end
Summary: Web Inspector: InstrumentingAgents should be registered in InspectorInstrumen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-17 07:44 PST by Yury Semikhatsky
Modified: 2013-01-17 11:43 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2013-01-17 07:46 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-01-17 07:44:27 PST 
Currently InspectorInstrumentation::registerInstrumentingAgents is called in InspectorController constructor which is suboptimal as it is enough to register corresponding InstrumentingAgents only while front-end is attached to the InspectorController.
Comment 1 Yury Semikhatsky 2013-01-17 07:46:17 PST 
Created attachment 183184 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-17 11:43:42 PST 
Comment on attachment 183184 [details]
Patch

Clearing flags on attachment: 183184

Committed r140015: <http://trac.webkit.org/changeset/140015>
Comment 3 WebKit Review Bot 2013-01-17 11:43:46 PST 
All reviewed patches have been landed.  Closing bug.