Bug 107117 - PDFPlugin: Build PDFPlugin everywhere, enable at runtime
Summary: PDFPlugin: Build PDFPlugin everywhere, enable at runtime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-17 05:03 PST by Tim Horton
Modified: 2013-01-22 00:41 PST (History)
3 users (show)

See Also:

Attachments
patch (6.45 KB, patch)
2013-01-17 05:05 PST, Tim Horton 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-17 05:03:20 PST 
Since PDFLayerController SPI is all forward-declared, this should build anywhere, and can be enabled/disabled at runtime.
Comment 1 Tim Horton 2013-01-17 05:05:29 PST 
Created attachment 183168 [details]
patch
Comment 2 Alexey Proskuryakov 2013-01-17 08:48:26 PST 
Comment on attachment 183168 [details]
patch

r=me on the assumption that there is enough runtime detection in place already to not break PDFs in nightlies.
Comment 3 Tim Horton 2013-01-22 00:30:32 PST 
(In reply to comment #2)
> (From update of attachment 183168 [details])
> r=me on the assumption that there is enough runtime detection in place already to not break PDFs in nightlies.

Not... exactly. It's an off-by-default setting. So there's no runtime detection; things will break if you flip the setting, but that's your own fault :D It won't break the nightlies.

I'm going to land this and file another bug about making the setting's default value depend on the existence of PDFLayerController.
Comment 4 Tim Horton 2013-01-22 00:40:04 PST 
http://trac.webkit.org/changeset/140394
Comment 5 Tim Horton 2013-01-22 00:41:25 PST 
(In reply to comment #3)
> I'm going to land this and file another bug about making the setting's default value depend on the existence of PDFLayerController.

--> https://bugs.webkit.org/show_bug.cgi?id=107514