Steps to reproduce (on Mac): 1. Open a source in the Sources panel (e.g. JavaScript) 2. Hit Cmd-F and type a substring that is found in the open resource, press Enter. A match is highlighted. 3. Hit Cmd-F once again. This should be a no-op, but instead, the search box contents are cleared and replaced by the "Find" placeholder
Created attachment 183361 [details] Patch
Comment on attachment 183361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183361&action=review > Source/WebCore/inspector/front-end/SearchController.js:253 > + if (selection.rangeCount) { I think you should first check for WebInspector.currentFocusElement() !== this._searchInputElemen and only if that is true, grap the window.getSelection().
Comment on attachment 183361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183361&action=review >> Source/WebCore/inspector/front-end/SearchController.js:253 >> + if (selection.rangeCount) { > > I think you should first check for WebInspector.currentFocusElement() !== this._searchInputElemen and only if that is true, grap the window.getSelection(). oh yeah sure. Will upload a new patch. Thank you!
Created attachment 183369 [details] Patch
Comment on attachment 183369 [details] Patch Thank you!
Comment on attachment 183369 [details] Patch Clearing flags on attachment: 183369 Committed r140109: <http://trac.webkit.org/changeset/140109>
All reviewed patches have been landed. Closing bug.