RESOLVED FIXED 107109
Web Inspector: Search shortcut clears the current search box contents 
https://bugs.webkit.org/show_bug.cgi?id=107109
Summary Web Inspector: Search shortcut clears the current search box contents
Alexander Pavlov (apavlov)
Reported 2013-01-17 02:54:58 PST
Steps to reproduce (on Mac): 1. Open a source in the Sources panel (e.g. JavaScript) 2. Hit Cmd-F and type a substring that is found in the open resource, press Enter. A match is highlighted. 3. Hit Cmd-F once again. This should be a no-op, but instead, the search box contents are cleared and replaced by the "Find" placeholder
Attachments
Patch (1.76 KB, patch)
2013-01-17 20:52 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2013-01-17 21:24 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-01-17 20:52:59 PST
Created attachment 183361 [details] Patch
Pavel Feldman
Comment 2 2013-01-17 21:11:28 PST
Comment on attachment 183361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183361&action=review > Source/WebCore/inspector/front-end/SearchController.js:253 > + if (selection.rangeCount) { I think you should first check for WebInspector.currentFocusElement() !== this._searchInputElemen and only if that is true, grap the window.getSelection().
Vivek Galatage
Comment 3 2013-01-17 21:22:31 PST
Comment on attachment 183361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183361&action=review >> Source/WebCore/inspector/front-end/SearchController.js:253 >> + if (selection.rangeCount) { > > I think you should first check for WebInspector.currentFocusElement() !== this._searchInputElemen and only if that is true, grap the window.getSelection(). oh yeah sure. Will upload a new patch. Thank you!
Vivek Galatage
Comment 4 2013-01-17 21:24:32 PST
Created attachment 183369 [details] Patch
Vivek Galatage
Comment 5 2013-01-18 01:01:20 PST
Comment on attachment 183369 [details] Patch Thank you!
WebKit Review Bot
Comment 6 2013-01-18 01:30:51 PST
Comment on attachment 183369 [details] Patch Clearing flags on attachment: 183369 Committed r140109: <http://trac.webkit.org/changeset/140109>
WebKit Review Bot
Comment 7 2013-01-18 01:30:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.