Bug 107108 - [WK2] TiledCoreAnimationDrawingArea should unparent its layer tree when requested
Summary: [WK2] TiledCoreAnimationDrawingArea should unparent its layer tree when reque...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-17 02:24 PST by Tim Horton
Modified: 2013-01-17 13:10 PST (History)
7 users (show)

See Also:

Attachments
patch (2.55 KB, patch)
2013-01-17 02:28 PST, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-17 02:24:13 PST 
Currently, TiledCoreAnimationDrawingArea returns early if asked to unparent its layer tree, to prevent flashing when switching tabs. We have new plans to alleviate the flashing, but first, we should reinstate unparenting the root layer.

<rdar://problem/12549879>
Comment 1 Tim Horton 2013-01-17 02:28:01 PST 
Created attachment 183155 [details]
patch
Comment 2 Tim Horton 2013-01-17 11:02:54 PST 
Thanks, Darin!

http://trac.webkit.org/changeset/140002
Comment 3 Benjamin Poulain 2013-01-17 12:59:58 PST 
There are 20 failed assertion on the debug bot: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r140002%20(5931)/results.html

This may be the cause.
Comment 4 Tim Horton 2013-01-17 13:10:07 PST 
(In reply to comment #3)
> There are 20 failed assertion on the debug bot: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r140002%20(5931)/results.html
> 
> This may be the cause.

Whoops. Fixed in http://trac.webkit.org/changeset/140033