Bug 107107 - [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
Summary: [BlackBerry] DRT - Accept http/file URL when running drt-launcher from comman...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-17 01:56 PST by Xiaobo Wang
Modified: 2013-01-17 20:43 PST (History)
5 users (show)

See Also:

Attachments
patch (2.93 KB, patch)
2013-01-17 02:06 PST, Xiaobo Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaobo Wang 2013-01-17 01:56:49 PST 
Currently we only accept DRT test file (relative to webkit/LayoutTests).
Developers have an requirement to dump render tree from command line for
http:// URL, as well as relative/absolute file path.
Comment 1 Xiaobo Wang 2013-01-17 02:06:03 PST 
Created attachment 183152 [details]
patch
Comment 2 Rob Buis 2013-01-17 11:06:58 PST 
Comment on attachment 183152 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176
> +}

I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector?
Comment 3 Xiaobo Wang 2013-01-17 18:01:54 PST 
Comment on attachment 183152 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review

>> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176
>> +}
> 
> I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector?

Yes, I'm expecting more protocols to be added, such as https://. If we only consider these two, I can update the patch to make it simple.
Comment 4 Rob Buis 2013-01-17 18:21:07 PST 
Comment on attachment 183152 [details]
patch

Ok.
Comment 5 WebKit Review Bot 2013-01-17 20:43:03 PST 
Comment on attachment 183152 [details]
patch

Clearing flags on attachment: 183152

Committed r140100: <http://trac.webkit.org/changeset/140100>
Comment 6 WebKit Review Bot 2013-01-17 20:43:06 PST 
All reviewed patches have been landed.  Closing bug.