Bug 107098 - Add a USE() macro for content filtering code
Summary: Add a USE() macro for content filtering code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 23:22 PST by Andy Estes
Modified: 2013-01-28 11:58 PST (History)
5 users (show)

See Also:

Attachments
Patch (36.51 KB, patch)
2013-01-16 23:35 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (12.95 KB, patch)
2013-01-17 00:36 PST, Andy Estes 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-01-16 23:22:31 PST 
Add an ENABLE() macro for content filtering code
Comment 1 Andy Estes 2013-01-16 23:35:11 PST 
Created attachment 183128 [details]
Patch
Comment 2 mitz 2013-01-16 23:47:03 PST 
Comment on attachment 183128 [details]
Patch

Mark Rowe suggested that USE() is more appropriate for this, and on second thought, I agree.
Comment 3 Andy Estes 2013-01-17 00:36:52 PST 
Created attachment 183134 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2013-01-17 08:33:22 PST 
Comment on attachment 183134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183134&action=review

> Source/WebCore/WebCore.exp.in:2155
>  #if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
>  _wkExecutableWasLinkedOnOrBeforeLion
> +#endif

Nit:  I would just move this down to the other "#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080" block below.
Comment 5 Andy Estes 2013-01-21 14:46:25 PST 
Committed r140366: <http://trac.webkit.org/changeset/140366>
Comment 6 David Kilzer (:ddkilzer) 2013-01-28 11:58:52 PST 
(In reply to comment #5)
> Committed r140366: <http://trac.webkit.org/changeset/140366>

Follow-up build fix in r140988:  <http://trac.webkit.org/changeset/140988>