Bug 107094 - 32-bit build for Qt5 on Mac OS fails.
Summary: 32-bit build for Qt5 on Mac OS fails.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 22:11 PST by Poul Sysolyatin
Modified: 2013-01-17 12:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.51 KB, patch)
2013-01-16 22:33 PST, Poul Sysolyatin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Poul Sysolyatin 2013-01-16 22:11:06 PST 
32-bit build for Qt5 on Mac OS fails.
Comment 1 Poul Sysolyatin 2013-01-16 22:33:48 PST 
Created attachment 183123 [details]
Patch
Comment 2 Andras Becsi 2013-01-17 01:20:41 PST 
Comment on attachment 183123 [details]
Patch

You can ask for review with setting r? and a reviewer will set r+.
Comment 3 Simon Hausmann 2013-01-17 07:59:34 PST 
Patch looks good to me, but I cannot review it as it touches a file in WebKit2.
Comment 4 Benjamin Poulain 2013-01-17 12:28:50 PST 
Comment on attachment 183123 [details]
Patch

It is a bit weird to use NS_BUILD_32_LIKE_64 for a lib.
But if Simon says okay, that's okay with me.
Comment 5 WebKit Review Bot 2013-01-17 12:42:05 PST 
Comment on attachment 183123 [details]
Patch

Clearing flags on attachment: 183123

Committed r140029: <http://trac.webkit.org/changeset/140029>
Comment 6 WebKit Review Bot 2013-01-17 12:42:09 PST 
All reviewed patches have been landed.  Closing bug.