RESOLVED FIXED 107091
Use xcrun to find path to make for Mac port 
https://bugs.webkit.org/show_bug.cgi?id=107091
Summary Use xcrun to find path to make for Mac port
David Kilzer (:ddkilzer)
Reported 2013-01-16 21:10:21 PST
Created attachment 183113 [details] Patch <http://webkit.org/b/000000> Reviewed by NOBODY (OOPS!). * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort._build_java_test_support): Call self.make_command(). (MacPort.make_command): Add. Tries to find a path for the make command using xcrun. Falls back to returning '/usr/bin/make'. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort._build_java_test_support): Call self.make_command(). (MacPort.make_command): Add. Call xcrun_find(). (MacPort.nm_command): Use self.xcrun_find(). (MacPort.xcrun_find): Add. Extract from nm_command(). --- 2 files changed, 29 insertions(+), 5 deletions(-)
Attachments
Patch (2.98 KB, patch)
2013-01-16 21:10 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.71 KB, patch)
2013-01-16 21:12 PST, David Kilzer (:ddkilzer) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2013-01-16 21:12:41 PST
Created attachment 183115 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 2 2013-01-16 21:22:41 PST
(In reply to comment #1) > Created an attachment (id=183115) [details] > Patch v2 Heh, python needs 'return' statements to actually return values. Will land this manually with those added.
David Kilzer (:ddkilzer)
Comment 3 2013-01-16 21:33:23 PST
Committed r139965: <http://trac.webkit.org/changeset/139965>
Eric Seidel (no email)
Comment 4 2013-01-16 22:24:17 PST
Comment on attachment 183115 [details] Patch v2 Fantastic.
Note You need to log in before you can comment on or make changes to this bug.