Bug 107091 - Use xcrun to find path to make for Mac port
Summary: Use xcrun to find path to make for Mac port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 21:10 PST by David Kilzer (:ddkilzer)
Modified: 2013-01-16 22:24 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2013-01-16 21:10 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (2.71 KB, patch)
2013-01-16 21:12 PST, David Kilzer (:ddkilzer) 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-01-16 21:10:21 PST 
Created attachment 183113 [details]
Patch

<http://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add.  Tries to find a path for the make
command using xcrun.  Falls back to returning '/usr/bin/make'.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add.  Call xcrun_find().
(MacPort.nm_command): Use self.xcrun_find().
(MacPort.xcrun_find): Add.  Extract from nm_command().
---
 2 files changed, 29 insertions(+), 5 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2013-01-16 21:12:41 PST 
Created attachment 183115 [details]
Patch v2
Comment 2 David Kilzer (:ddkilzer) 2013-01-16 21:22:41 PST 
(In reply to comment #1)
> Created an attachment (id=183115) [details]
> Patch v2

Heh, python needs 'return' statements to actually return values.  Will land this manually with those added.
Comment 3 David Kilzer (:ddkilzer) 2013-01-16 21:33:23 PST 
Committed r139965: <http://trac.webkit.org/changeset/139965>
Comment 4 Eric Seidel (no email) 2013-01-16 22:24:17 PST 
Comment on attachment 183115 [details]
Patch v2

Fantastic.