Bug 107089 - Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement instead of toTextFormControl
Summary: Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement inste...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on: 106533
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-16 20:45 PST by Shinya Kawanaka
Modified: 2013-01-18 16:14 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.22 KB, patch)
2013-01-17 20:42 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2013-01-17 22:16 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (10.87 KB, patch)
2013-01-17 23:12 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2013-01-16 20:45:25 PST 
This is a follow-up bug for Bug 106533.

It seems no one didn't ensure Position of enclosingTextFormControl() points ShadowDOM in input or textarea.
We would like to have some ASSERT or something.
Comment 1 Shinya Kawanaka 2013-01-17 20:33:38 PST 
toTextFormControl() returns 0 if it's not TextFormControl.

I don't think this function aligns recent coding convention...
It would be better to rewrite it.
Comment 2 Shinya Kawanaka 2013-01-17 20:42:42 PST 
Created attachment 183360 [details]
Patch
Comment 3 Early Warning System Bot 2013-01-17 20:49:09 PST 
Comment on attachment 183360 [details]
Patch

Attachment 183360 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15943318
Comment 4 Early Warning System Bot 2013-01-17 21:46:27 PST 
Comment on attachment 183360 [details]
Patch

Attachment 183360 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15943349
Comment 5 Shinya Kawanaka 2013-01-17 21:52:15 PST 
Ah some WebKit ports uses toTextFormControl()... :-(
Comment 6 Shinya Kawanaka 2013-01-17 22:16:52 PST 
Created attachment 183375 [details]
Patch
Comment 7 Early Warning System Bot 2013-01-17 22:30:09 PST 
Comment on attachment 183375 [details]
Patch

Attachment 183375 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15946266
Comment 8 Early Warning System Bot 2013-01-17 22:33:49 PST 
Comment on attachment 183375 [details]
Patch

Attachment 183375 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15937548
Comment 9 Shinya Kawanaka 2013-01-17 23:12:27 PST 
Created attachment 183383 [details]
Patch
Comment 10 Kent Tamura 2013-01-18 00:58:14 PST 
Comment on attachment 183383 [details]
Patch

Looks ok.
Please watch buildbots especially GTK bots after landing this.
Comment 11 WebKit Review Bot 2013-01-18 16:14:20 PST 
Comment on attachment 183383 [details]
Patch

Clearing flags on attachment: 183383

Committed r140215: <http://trac.webkit.org/changeset/140215>
Comment 12 WebKit Review Bot 2013-01-18 16:14:24 PST 
All reviewed patches have been landed.  Closing bug.