RESOLVED FIXED Bug 107089
Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement instead of toTextFormControl 
https://bugs.webkit.org/show_bug.cgi?id=107089
Summary Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement inste...
Shinya Kawanaka
Reported 2013-01-16 20:45:25 PST
This is a follow-up bug for Bug 106533. It seems no one didn't ensure Position of enclosingTextFormControl() points ShadowDOM in input or textarea. We would like to have some ASSERT or something.
Attachments
Patch (8.22 KB, patch)
2013-01-17 20:42 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (10.86 KB, patch)
2013-01-17 22:16 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (10.87 KB, patch)
2013-01-17 23:12 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2013-01-17 20:33:38 PST
toTextFormControl() returns 0 if it's not TextFormControl. I don't think this function aligns recent coding convention... It would be better to rewrite it.
Shinya Kawanaka
Comment 2 2013-01-17 20:42:42 PST
Created attachment 183360 [details] Patch
Early Warning System Bot
Comment 3 2013-01-17 20:49:09 PST
Comment on attachment 183360 [details] Patch Attachment 183360 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15943318
Early Warning System Bot
Comment 4 2013-01-17 21:46:27 PST
Comment on attachment 183360 [details] Patch Attachment 183360 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15943349
Shinya Kawanaka
Comment 5 2013-01-17 21:52:15 PST
Ah some WebKit ports uses toTextFormControl()... :-(
Shinya Kawanaka
Comment 6 2013-01-17 22:16:52 PST
Created attachment 183375 [details] Patch
Early Warning System Bot
Comment 7 2013-01-17 22:30:09 PST
Comment on attachment 183375 [details] Patch Attachment 183375 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15946266
Early Warning System Bot
Comment 8 2013-01-17 22:33:49 PST
Comment on attachment 183375 [details] Patch Attachment 183375 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15937548
Shinya Kawanaka
Comment 9 2013-01-17 23:12:27 PST
Created attachment 183383 [details] Patch
Kent Tamura
Comment 10 2013-01-18 00:58:14 PST
Comment on attachment 183383 [details] Patch Looks ok. Please watch buildbots especially GTK bots after landing this.
WebKit Review Bot
Comment 11 2013-01-18 16:14:20 PST
Comment on attachment 183383 [details] Patch Clearing flags on attachment: 183383 Committed r140215: <http://trac.webkit.org/changeset/140215>
WebKit Review Bot
Comment 12 2013-01-18 16:14:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.