Bug 107085 - [BlackBerry] Need to adjust the scale and scroll position after leaving fullscreen mode if there's device rotation in fullscreen mode
Summary: [BlackBerry] Need to adjust the scale and scroll position after leaving fulls...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 19:17 PST by Charles Wei
Modified: 2013-01-16 19:54 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.45 KB, patch)
2013-01-16 19:27 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2013-01-16 19:17:02 PST
We saved the scale and scroll position before entering full screen mode, so that we can restore them after leaving fullscreen mode, because entering fullscreen mode automatically changes the scale to make the video to fit to the viewport. But if there's device rotation during the fullscreen, the scale and scroll position saved before may or may not apply anymore,  we need to adjust the scale and/or scroll position if needed to make sure no over-scale or over-scroll in the new orientation.
Comment 1 Charles Wei 2013-01-16 19:27:15 PST
Created attachment 183100 [details]
Patch
Comment 2 Charles Wei 2013-01-16 19:28:49 PST
Comment on attachment 183100 [details]
Patch

Already reviewed by George Staikos. Commit it.
Comment 3 WebKit Review Bot 2013-01-16 19:54:18 PST
Comment on attachment 183100 [details]
Patch

Clearing flags on attachment: 183100

Committed r139955: <http://trac.webkit.org/changeset/139955>
Comment 4 WebKit Review Bot 2013-01-16 19:54:21 PST
All reviewed patches have been landed.  Closing bug.