Bug 107084 - Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer.
Summary: Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks: 103854
  Show dependency tree / graph
 
Reported: 2013-01-16 19:06 PST by Dongseong Hwang
Modified: 2013-01-17 14:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2013-01-16 19:08 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-01-16 19:06:34 PST 
There are two changes.
1. It is redundant to call GraphicsLayer::removeFromParent() or GraphicsLayer::removeAllChildren() before deleting GraphicsLayer, because the destructor of GraphicsLayerTextureMapper does those.
2. LayerTreeRenderer::setRootLayerID() does not need to remove all children of rootLayer because this method can be called only once.
Comment 1 Dongseong Hwang 2013-01-16 19:08:55 PST 
Created attachment 183096 [details]
Patch
Comment 2 Noam Rosenthal 2013-01-16 23:41:21 PST 
Comment on attachment 183096 [details]
Patch

I would consider this trivial; Allowing myself to r+.
Comment 3 WebKit Review Bot 2013-01-17 14:56:33 PST 
Comment on attachment 183096 [details]
Patch

Clearing flags on attachment: 183096

Committed r140053: <http://trac.webkit.org/changeset/140053>
Comment 4 WebKit Review Bot 2013-01-17 14:56:37 PST 
All reviewed patches have been landed.  Closing bug.