WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107084
Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer.
https://bugs.webkit.org/show_bug.cgi?id=107084
Summary
Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer.
Dongseong Hwang
Reported
2013-01-16 19:06:34 PST
There are two changes. 1. It is redundant to call GraphicsLayer::removeFromParent() or GraphicsLayer::removeAllChildren() before deleting GraphicsLayer, because the destructor of GraphicsLayerTextureMapper does those. 2. LayerTreeRenderer::setRootLayerID() does not need to remove all children of rootLayer because this method can be called only once.
Attachments
Patch
(2.61 KB, patch)
2013-01-16 19:08 PST
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2013-01-16 19:08:55 PST
Created
attachment 183096
[details]
Patch
Noam Rosenthal
Comment 2
2013-01-16 23:41:21 PST
Comment on
attachment 183096
[details]
Patch I would consider this trivial; Allowing myself to r+.
WebKit Review Bot
Comment 3
2013-01-17 14:56:33 PST
Comment on
attachment 183096
[details]
Patch Clearing flags on attachment: 183096 Committed
r140053
: <
http://trac.webkit.org/changeset/140053
>
WebKit Review Bot
Comment 4
2013-01-17 14:56:37 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug