RESOLVED FIXED 107083
Introduce BackgroundHTMLParser for parsing HTML on a background thread 
https://bugs.webkit.org/show_bug.cgi?id=107083
Summary Introduce BackgroundHTMLParser for parsing HTML on a background thread
Adam Barth
Reported 2013-01-16 18:43:07 PST
Introduce BackgroundHTMLParser for parsing HTML on a background thread
Attachments
Patch (29.13 KB, patch)
2013-01-16 18:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-01-16 18:49:40 PST
Created attachment 183091 [details] Patch
Eric Seidel (no email)
Comment 2 2013-01-16 18:52:03 PST
Comment on attachment 183091 [details] Patch This is very primitive. But looks OK. I'm not sure I'm your ideal reviewer having written much of this, but that's true of tony too.
Adam Barth
Comment 3 2013-01-16 18:56:51 PST
Comment on attachment 183091 [details] Patch Clearing flags on attachment: 183091 Committed r139950: <http://trac.webkit.org/changeset/139950>
Adam Barth
Comment 4 2013-01-16 18:56:55 PST
All reviewed patches have been landed. Closing bug.
Tony Gentilcore
Comment 5 2013-01-16 19:06:41 PST
Comment on attachment 183091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183091&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:106 > + DEFINE_STATIC_LOCAL(AtomicString, iframeTag, ("iframe", AtomicString::ConstructFromLiteral)); Is it worth adding a FIXME about our plan for AtomicStrings? > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:164 > +class TokenDelivery { Mark this noncopyable? > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:175 > + delete delivery; Is there anything we can do better than a naked delete?
Adam Barth
Comment 6 2013-01-16 19:17:27 PST
Sorry, this patch already landed. I'm posting a followup patch now.
Adam Barth
Comment 7 2013-01-16 19:20:00 PST
Followup is in bug 107086
Note You need to log in before you can comment on or make changes to this bug.