Bug 107082 - Introduce a method to build the tree from a CompactHTMLToken
Summary: Introduce a method to build the tree from a CompactHTMLToken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-01-16 18:34 PST by Tony Gentilcore
Modified: 2013-01-16 19:38 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.42 KB, patch)
2013-01-16 18:35 PST, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2013-01-16 18:41 PST, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch for landing (6.06 KB, patch)
2013-01-16 18:59 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-01-16 18:34:43 PST 
Introduce a method to build the tree from a CompactHTMLToken
Comment 1 Tony Gentilcore 2013-01-16 18:35:22 PST 
Created attachment 183088 [details]
Patch
Comment 2 Adam Barth 2013-01-16 18:39:42 PST 
Comment on attachment 183088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183088&action=review

> Source/WebCore/html/parser/HTMLToken.h:121
> +        case HTMLTokenTypes::EndTag: {

I'd skip the { } here since we don't have them for other cases.
Comment 3 Tony Gentilcore 2013-01-16 18:40:29 PST 
(In reply to comment #2)
> (From update of attachment 183088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183088&action=review
> 
> > Source/WebCore/html/parser/HTMLToken.h:121
> > +        case HTMLTokenTypes::EndTag: {
> 
> I'd skip the { } here since we don't have them for other cases.

Fixed
Comment 4 Tony Gentilcore 2013-01-16 18:41:27 PST 
Created attachment 183090 [details]
Patch
Comment 5 Adam Barth 2013-01-16 18:59:41 PST 
Created attachment 183094 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-01-16 19:38:14 PST 
Comment on attachment 183094 [details]
Patch for landing

Clearing flags on attachment: 183094

Committed r139953: <http://trac.webkit.org/changeset/139953>
Comment 7 WebKit Review Bot 2013-01-16 19:38:17 PST 
All reviewed patches have been landed.  Closing bug.