WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107061
[WK2] Don't use NSApplication run loop in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=107061
Summary
[WK2] Don't use NSApplication run loop in NetworkProcess
Alexey Proskuryakov
Reported
2013-01-16 16:05:30 PST
Entering the NSApplication run loop initializes a number of subsystems that we don't need, and thus needs a less strict sandbox than necessary.
Attachments
proposed patch
(5.88 KB, patch)
2013-01-16 16:09 PST
,
Alexey Proskuryakov
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-01-16 16:09:48 PST
Created
attachment 183053
[details]
proposed patch
Anders Carlsson
Comment 2
2013-01-17 10:03:20 PST
Comment on
attachment 183053
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=183053&action=review
> Source/WebCore/platform/mac/RunLoopMac.mm:36 > +void RunLoop::setUseApplicationRunLoopOnMainRunLoop() > +{ > + s_useApplicationRunLoopOnMainRunLoop = true; > +}
Can we assert that the main run loop has not yet been created here?
Alexey Proskuryakov
Comment 3
2013-01-17 10:12:00 PST
Committed <
http://trac.webkit.org/changeset/139985
>.
> Can we assert that the main run loop has not yet been created here?
Sadly not without some major refactoring, the main run loop is created very early, before we know what kind of process it is.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug