Bug 107060 - [EFL][WK2] PageUIClientEfl should keep in sync with WKPageUIClient
Summary: [EFL][WK2] PageUIClientEfl should keep in sync with WKPageUIClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 16:03 PST by Jaehun Lim
Modified: 2013-01-16 17:12 PST (History)
5 users (show)

See Also:

Attachments
Patch (13.42 KB, patch)
2013-01-16 16:12 PST, Jaehun Lim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2013-01-16 16:03:09 PST 
Rearrange the order of functions in PageUIClientEfl
Comment 1 Jaehun Lim 2013-01-16 16:12:58 PST 
Created attachment 183054 [details]
Patch
Comment 2 Benjamin Poulain 2013-01-16 16:43:44 PST 
Comment on attachment 183054 [details]
Patch

Not sure why the implementation of the Color Input type is where it is. That's not important :)

Thanks for splitting the patches.
Comment 3 Benjamin Poulain 2013-01-16 16:48:42 PST 
Comment on attachment 183054 [details]
Patch

I trust you it build on EFL :)
Comment 4 Jaehun Lim 2013-01-16 16:50:14 PST 
(In reply to comment #3)
> (From update of attachment 183054 [details])
> I trust you it build on EFL :)

Thanks for your fast review.
Comment 5 WebKit Review Bot 2013-01-16 17:05:20 PST 
Comment on attachment 183054 [details]
Patch

Rejecting attachment 183054 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/15915010
Comment 6 Ryuan Choi 2013-01-16 17:09:02 PST 
Comment on attachment 183054 [details]
Patch

cq bot looks sick.

try once more.
Comment 7 WebKit Review Bot 2013-01-16 17:12:41 PST 
Comment on attachment 183054 [details]
Patch

Clearing flags on attachment: 183054

Committed r139937: <http://trac.webkit.org/changeset/139937>
Comment 8 WebKit Review Bot 2013-01-16 17:12:45 PST 
All reviewed patches have been landed.  Closing bug.