Bug 107060 – [EFL][WK2] PageUIClientEfl should keep in sync with WKPageUIClient

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jaehun Lim]

Rearrange the order of functions in PageUIClientEfl

[Jaehun Lim]

Created attachment 183054 [details]
Patch

[Benjamin Poulain]

Comment on attachment 183054 [details]
Patch

Not sure why the implementation of the Color Input type is where it is. That's not important :)

Thanks for splitting the patches.

[Benjamin Poulain]

Comment on attachment 183054 [details]
Patch

I trust you it build on EFL :)

[Jaehun Lim]

(In reply to comment #3)
> (From update of attachment 183054 [details])
> I trust you it build on EFL :)

Thanks for your fast review.

[WebKit Review Bot]

Comment on attachment 183054 [details]
Patch

Rejecting attachment 183054 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/15915010

[Ryuan Choi]

Comment on attachment 183054 [details]
Patch

cq bot looks sick.

try once more.

[WebKit Review Bot]

Comment on attachment 183054 [details]
Patch

Clearing flags on attachment: 183054

Committed r139937: <http://trac.webkit.org/changeset/139937>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.