RESOLVED FIXED107057
Replaced specifiers variable with is_debug in builders.py 
https://bugs.webkit.org/show_bug.cgi?id=107057
Summary Replaced specifiers variable with is_debug in builders.py
Timothy Loh
Reported 2013-01-16 15:35:10 PST
The only used item in the specifiers set is "debug", so we can simplify this to just having an is_debug variable. This will allow Bug 106259 to be more easily facilitated.
Attachments
Patch (8.94 KB, patch)
2013-01-16 15:39 PST, Timothy Loh 		no flags
DetailsFormatted DiffDiff
Patch (10.18 KB, patch)
2013-01-16 19:20 PST, Timothy Loh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Loh
Comment 1 2013-01-16 15:39:35 PST
Created attachment 183046 [details] Patch
Eric Seidel (no email)
Comment 2 2013-01-16 15:48:49 PST
dpranke is your man. I guess the logic here is that everything else is already encoded in the port name?
Timothy Loh
Comment 3 2013-01-16 16:03:40 PST
(In reply to comment #2) > dpranke is your man. I guess the logic here is that everything else is already encoded in the port name? The removed specifiers are all in the port name except for word size, but that is only listed for a few builders so it probably isn't too useful anyway.
Dirk Pranke
Comment 4 2013-01-16 16:21:54 PST
Comment on attachment 183046 [details] Patch This generally seems like an improvement. I have long suspect that the specifiers list was underused. One note, though: if the only bot we have for a port is a debug bot, builder_name_for_port_name() won't be correct. Of course, it already wasn't correct.
Timothy Loh
Comment 5 2013-01-16 19:20:00 PST
Created attachment 183098 [details] Patch
WebKit Review Bot
Comment 6 2013-01-17 12:38:39 PST
Comment on attachment 183098 [details] Patch Clearing flags on attachment: 183098 Committed r140026: <http://trac.webkit.org/changeset/140026>
WebKit Review Bot
Comment 7 2013-01-17 12:38:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.