Bug 107053 – [CSS Grid Layout] infinity should be defined as a negative value

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Julien Chaffraix]

Filed http://lists.w3.org/Archives/Public/www-style/2013Jan/0216.html as a specification bug.

If the proposal is accepted, we could change the code from bug 106474 to use a negative value for infinity (-1 for example) and have some getters / setters that hide this information from the rest of the code. This would avoid the clash with a possible return value from computeUsedBreadthOfSpecifiedLength.

Considering that it's a corner case, it's a low priority but nice to fix.

[Sergio Villar Senin]

The fix is supereasy but I'm setting the BlinkMergeCandidate keyword because it'd be interesting to share the same layout test code.

This is the relevant commit in Blink:

  [CSS Grid Layout] infinity should be defined as a negative value

  This change makes us reject negative lengths at parse time, which
  matches the updated specification, so that we can now safely assume
  that when we resolve the length, it is not to a negative value.

  BUG=234209
  TESTS=fast/css-grid-layout/grid-columns-rows-get-set.html
        fast/css-grid-layout/grid-columns-rows-get-set-multiple.html

  Review URL: https://chromiumcodereview.appspot.com/19668006

[Sergio Villar Senin]

Created attachment 208201 [details]
Patch

[Build Bot]

Comment on attachment 208201 [details]
Patch

Attachment 208201 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1350262

New failing tests:
webaudio/delaynode-max-default-delay.html

[Build Bot]

Created attachment 208214 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Sergio Villar Senin]

(In reply to comment #3)
> (From update of attachment 208201 [details])
> Attachment 208201 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/1350262
> 
> New failing tests:
> webaudio/delaynode-max-default-delay.html

Totally unrelated to the patch.

[Sergio Villar Senin]

Committed r154730: <http://trac.webkit.org/changeset/154730>