WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
107051
REGRESSION(
r137248
): TexMap does not draw many graphics layers in google gravity.
https://bugs.webkit.org/show_bug.cgi?id=107051
Summary
REGRESSION(r137248): TexMap does not draw many graphics layers in google grav...
Dongseong Hwang
Reported
2013-01-16 14:34:35 PST
TexMap skipped many layers in
http://mrdoob.com/projects/chromeexperiments/google-gravity/
It is because RenderLayerBacking does not call GraphicsLayer::setNeedsDisplay() Following raw change can fix this bug. --- a/Source/WebCore/rendering/RenderLayerBacking.cpp +++ b/Source/WebCore/rendering/RenderLayerBacking.cpp @@ -670,7 +670,7 @@ void RenderLayerBacking::updateGraphicsLayerGeometry() // Usually invalidation will happen via layout etc, but if we've affected the layer // size by constraining relative to a clipping ancestor or the viewport, we // have to invalidate to avoid showing stretched content. - if (m_boundsConstrainedByClipping) +// if (m_boundsConstrainedByClipping) m_graphicsLayer->setNeedsDisplay(); } m_boundsConstrainedByClipping was created in
Bug 104626
. I suspect m_boundsConstrainedByClipping does not concern about delegatesScrolling or paintsEntireContents or useFixedLayout or fixedLayoutSize.
Attachments
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2013-01-16 14:37:26 PST
We can reproduce using Qt WK1, GTK WK1 and WK2. Coordinated Graphics is fine. I think creating TiledBackingStore causes at least painting once without setNeedsDisplay or setNeedsDisplayRect.
Dongseong Hwang
Comment 2
2013-01-16 16:06:00 PST
(In reply to
comment #1
)
> We can reproduce using Qt WK1, GTK WK1 and WK2. > Coordinated Graphics is fine. I think creating TiledBackingStore causes at least painting once without setNeedsDisplay or setNeedsDisplayRect.
Coordinated Graphics has the same problem after
Bug 107059
that CoordinatedGraphicsLayer paints contents on a backing store only when RenderLayerBacking requests.
Dongseong Hwang
Comment 3
2013-01-29 01:16:54 PST
This bug disappeared.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug