Bug 107039 - Web Inspector: Crash at Console.cpp:216 (use of RefPtr after release to PassRefPtr)
Summary: Web Inspector: Crash at Console.cpp:216 (use of RefPtr after release to PassR...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 12:06 PST by Timothy Hatcher
Modified: 2013-01-16 18:59 PST (History)
9 users (show)

See Also:


Attachments
Proposed Change (2.99 KB, patch)
2013-01-16 12:09 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-01-16 12:06:05 PST
The arguments RefPtr is being released and later used.

I have some other tweaks in this function too.
Comment 1 Timothy Hatcher 2013-01-16 12:09:28 PST
Created attachment 183017 [details]
Proposed Change
Comment 2 Joseph Pecoraro 2013-01-16 12:12:45 PST
Comment on attachment 183017 [details]
Proposed Change

r=me

Although it might be nice to make a test for this. I'm surprised that it wasn't covered by existing tests.
Comment 3 WebKit Review Bot 2013-01-16 14:54:10 PST
Comment on attachment 183017 [details]
Proposed Change

Clearing flags on attachment: 183017

Committed r139927: <http://trac.webkit.org/changeset/139927>
Comment 4 WebKit Review Bot 2013-01-16 14:54:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2013-01-16 18:59:09 PST
Comment on attachment 183017 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=183017&action=review

> Source/WebCore/page/Console.cpp:218
> +            String argAsString = arguments->argumentAt(i).toString(arguments->globalState());
> +            printf(" %s", argAsString.utf8().data());

Could all be one line now without a local variable.