Bug 107006 - Web Inspector: fix text-editor-highlight-regexp test
Summary: Web Inspector: fix text-editor-highlight-regexp test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 05:21 PST by Andrey Lushnikov
Modified: 2013-01-16 07:14 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.52 KB, patch)
2013-01-16 05:41 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (5.61 KB, patch)
2013-01-16 06:44 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-01-16 05:21:33 PST 
Test was introduced here: http://trac.webkit.org/changeset/139844
It fails because font height differs on different platforms.
Comment 1 Andrey Lushnikov 2013-01-16 05:41:51 PST 
Created attachment 182967 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-16 06:20:17 PST 
Comment on attachment 182967 [details]
Patch

Rejecting attachment 182967 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/15904476
Comment 3 Andrey Lushnikov 2013-01-16 06:44:58 PST 
Created attachment 182974 [details]
Patch
Comment 4 Pavel Feldman 2013-01-16 07:14:36 PST 
Comment on attachment 182974 [details]
Patch

Clearing flags on attachment: 182974

Committed r139879: <http://trac.webkit.org/changeset/139879>
Comment 5 Pavel Feldman 2013-01-16 07:14:40 PST 
All reviewed patches have been landed.  Closing bug.