Bug 106998 - Web Inspector: array grouping does not work for float number keys
Summary: Web Inspector: array grouping does not work for float number keys
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
Depends on: 106891
  Show dependency treegraph
Reported: 2013-01-16 03:01 PST by Andrey Adaikin
Modified: 2013-01-16 08:57 PST (History)
9 users (show)

See Also:

Patch (5.88 KB, patch)
2013-01-16 03:03 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-01-16 03:01:22 PST
This is a follow-up to the https://bugs.webkit.org/show_bug.cgi?id=106891 fix, which was not quite correct.

Now we do the array index check according to the ECMAScript 5, section 15.4:
"A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 2^32-1."

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-16 03:03:28 PST
Created attachment 182949 [details]
Comment 2 WebKit Review Bot 2013-01-16 08:57:42 PST
Comment on attachment 182949 [details]

Clearing flags on attachment: 182949

Committed r139887: <http://trac.webkit.org/changeset/139887>
Comment 3 WebKit Review Bot 2013-01-16 08:57:45 PST
All reviewed patches have been landed.  Closing bug.