Bug 106980 - Allow PaintInfo to carry all PaintBehavior flags
Summary: Allow PaintInfo to carry all PaintBehavior flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 21:24 PST by Simon Fraser (smfr)
Modified: 2013-01-17 16:13 PST (History)
12 users (show)

See Also:

Attachments
Patch (12.87 KB, patch)
2013-01-15 21:30 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2013-01-16 13:44 PST, Simon Fraser (smfr) 		bdakin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-01-15 21:24:40 PST 
Allow PaintInfo to carry all PaintBehavior flags
Comment 1 Simon Fraser (smfr) 2013-01-15 21:30:08 PST 
Created attachment 182917 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-15 21:32:14 PST 
Attachment 182917 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/PaintInfo.h:56:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2013-01-16 12:02:35 PST 
http://trac.webkit.org/changeset/139908
Comment 4 Simon Fraser (smfr) 2013-01-16 13:36:18 PST 
I missed one.
Comment 5 Simon Fraser (smfr) 2013-01-16 13:44:40 PST 
Created attachment 183031 [details]
Patch
Comment 6 Build Bot 2013-01-16 15:54:45 PST 
Comment on attachment 183031 [details]
Patch

Attachment 183031 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15905628

New failing tests:
svg/as-image/img-relative-height.html
Comment 7 Simon Fraser (smfr) 2013-01-17 16:13:26 PST 
http://trac.webkit.org/changeset/140066