Bug 106974 - webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
Summary: webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 19:18 PST by Dirk Pranke
Modified: 2013-01-15 19:46 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2013-01-15 19:19 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2013-01-15 19:18:08 PST 
I forgot to stub out the call to check to ensure that the ports were available, so this test can fail if something is listening on 8000 or 8443, e.g.:

http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/8188/steps/webkitpy-test/logs/stdio
Comment 1 Dirk Pranke 2013-01-15 19:19:37 PST 
Created attachment 182905 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-15 19:46:02 PST 
Comment on attachment 182905 [details]
Patch

Clearing flags on attachment: 182905

Committed r139827: <http://trac.webkit.org/changeset/139827>
Comment 3 WebKit Review Bot 2013-01-15 19:46:05 PST 
All reviewed patches have been landed.  Closing bug.