Bug 106969 - [EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
Summary: [EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 18:33 PST by Gyuyoung Kim
Modified: 2013-01-16 02:18 PST (History)
6 users (show)

See Also:


Attachments
Patch (454.50 KB, patch)
2013-01-15 18:35 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (455.24 KB, patch)
2013-01-15 22:21 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-01-15 18:33:03 PST
DefaultTheme is used by both EFL WK1 and WK2 ports. So, WebCore/platform/efl is appropriate place for it.
Comment 1 Gyuyoung Kim 2013-01-15 18:35:09 PST
Created attachment 182896 [details]
Patch
Comment 2 Benjamin Poulain 2013-01-15 21:19:56 PST
Comment on attachment 182896 [details]
Patch

Only moving the files I assume?

No need for rebaseline of your WebKit2 layout test results?
Comment 3 Gyuyoung Kim 2013-01-15 21:21:10 PST
(In reply to comment #2)
> (From update of attachment 182896 [details])
> Only moving the files I assume?
> 
> No need for rebaseline of your WebKit2 layout test results?

Let me check it before landing. Thanks.
Comment 4 Gyuyoung Kim 2013-01-15 21:21:36 PST
(In reply to comment #2)
> (From update of attachment 182896 [details])
> Only moving the files I assume?
Yes, right. Only move the files.
Comment 5 EFL EWS Bot 2013-01-15 21:29:26 PST
Comment on attachment 182896 [details]
Patch

Attachment 182896 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15905247
Comment 6 Gyuyoung Kim 2013-01-15 22:21:07 PST
Created attachment 182919 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-01-15 22:28:47 PST
Attachment 182919 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/PlatformEfl.cmake', u..." exit_code: 1
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_focus.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Gyuyoung Kim 2013-01-16 00:41:10 PST
Comment on attachment 182919 [details]
Patch for landing

I don't want to touch other nits because this patch is just to move DefaultTheme place. And also, I think this patch won't influence on layout test result.
Comment 9 WebKit Review Bot 2013-01-16 02:18:07 PST
Comment on attachment 182919 [details]
Patch for landing

Clearing flags on attachment: 182919

Committed r139858: <http://trac.webkit.org/changeset/139858>
Comment 10 WebKit Review Bot 2013-01-16 02:18:11 PST
All reviewed patches have been landed.  Closing bug.