Bug 106951 - [chromium] Make new-style page scale work with fixed layout
Summary: [chromium] Make new-style page scale work with fixed layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 15:44 PST by Alexandre Elias
Modified: 2013-01-17 12:27 PST (History)
9 users (show)

See Also:

Attachments
Patch (17.15 KB, patch)
2013-01-15 15:54 PST, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (17.13 KB, patch)
2013-01-16 11:58 PST, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (17.74 KB, patch)
2013-01-16 21:33 PST, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2013-01-15 15:44:02 PST 
[chromium] Make new-style page scale work with fixed layout
Comment 1 Alexandre Elias 2013-01-15 15:54:08 PST 
Created attachment 182864 [details]
Patch
Comment 2 Alexandre Elias 2013-01-15 15:55:36 PST 
Chromium side of this change at: https://codereview.chromium.org/11958004/
Comment 3 Alexandre Elias 2013-01-16 11:58:43 PST 
Created attachment 183016 [details]
Patch

Change updateLayerTreeViewport layoutViewportSize to include desktop-style scrollbars
Comment 4 Alexandre Elias 2013-01-16 21:33:18 PST 
Created attachment 183117 [details]
Patch

Bring back relayout in didChangeContentsSize, still needed
Comment 5 Adam Barth 2013-01-16 21:42:51 PST 
Comment on attachment 183117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183117&action=review

I'm not able to verify every detail of this patch, but this definitely looks like an improvement.

> Source/WebKit/chromium/ChangeLog:13
> +        - dispatchViewportPropertiesDidChange() now works entirely with DIP
> +        pixels instead of physical pixels, and is made compatible with
> +        separating deviceScaleFactor from pageScaleFactor.

Great!
Comment 6 WebKit Review Bot 2013-01-17 12:27:51 PST 
Comment on attachment 183117 [details]
Patch

Clearing flags on attachment: 183117

Committed r140025: <http://trac.webkit.org/changeset/140025>
Comment 7 WebKit Review Bot 2013-01-17 12:27:55 PST 
All reviewed patches have been landed.  Closing bug.