Bug 106947 - Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
Summary: Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 15:04 PST by Simon Fraser (smfr)
Modified: 2013-01-15 15:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.04 KB, patch)
2013-01-15 15:06 PST, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-01-15 15:04:44 PST 
Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
Comment 1 Simon Fraser (smfr) 2013-01-15 15:06:12 PST 
Created attachment 182852 [details]
Patch
Comment 2 Darin Adler 2013-01-15 15:13:24 PST 
Comment on attachment 182852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182852&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:301
> +    m_ancestorClippingLayer = nullptr;

This looks like a small related bug fix, not a renaming of m_containmentLayer.
Comment 3 Simon Fraser (smfr) 2013-01-15 15:18:39 PST 
http://trac.webkit.org/changeset/139797
Comment 4 Simon Fraser (smfr) 2013-01-15 15:28:55 PST 
(In reply to comment #2)
> (From update of attachment 182852 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182852&action=review
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:301
> > +    m_ancestorClippingLayer = nullptr;
> 
> This looks like a small related bug fix, not a renaming of m_containmentLayer.

Indeed it was; noticed that this wasn't getting cleared. I should have mentioned it in the changelog.