WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WORKSFORME
Bug 106928
[CSS Exclusions] Float position determination does not always ignore margins when the float has a shape-outside
https://bugs.webkit.org/show_bug.cgi?id=106928
Summary
[CSS Exclusions] Float position determination does not always ignore margins ...
Bem Jones-Bey
Reported
2013-01-15 11:10:50 PST
Specifically, RenderBlock::xPositionForFloatIncludingMargin and RenderBlock::yPositionForFloatIncludingMargin do not ignore the margin if the float has a shape outside. It would be good to look for other cases as well when fixing this bug, but it might also be hard to find tests for this.
Attachments
Add attachment
proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1
2013-01-21 14:44:24 PST
When doing this, add a comment to these methods to explain that when floats have shape-outside, the FloatingObject has different size/coordinates than the RenderBox. (it is a bit confusing)
Bem Jones-Bey
Comment 2
2013-01-22 14:36:44 PST
I can't come up with any situations in which this actually is an issue, so I'm closing it. Things seem to work properly, and I think if I come up with an actual use case where this is a problem, I'll file a bug for that. This is almost too low level to be able to come up with a proper test case.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug