Bug 106928 - [CSS Exclusions] Float position determination does not always ignore margins when the float has a shape-outside
Summary: [CSS Exclusions] Float position determination does not always ignore margins ...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL: http://dev.w3.org/csswg/css3-exclusio...
Keywords:
Depends on:
Blocks: 98664
  Show dependency tree / graph
 
Reported: 2013-01-15 11:10 PST by Bem Jones-Bey
Modified: 2013-01-22 14:36 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-01-15 11:10:50 PST 
Specifically, RenderBlock::xPositionForFloatIncludingMargin and RenderBlock::yPositionForFloatIncludingMargin do not ignore the margin if the float has a shape outside.

It would be good to look for other cases as well when fixing this bug, but it might also be hard to find tests for this.
Comment 1 Bem Jones-Bey 2013-01-21 14:44:24 PST 
When doing this, add a comment to these methods to explain that when floats have shape-outside, the FloatingObject has different size/coordinates than the RenderBox. (it is a bit confusing)
Comment 2 Bem Jones-Bey 2013-01-22 14:36:44 PST 
I can't come up with any situations in which this actually is an issue, so I'm closing it. Things seem to work properly, and I think if I come up with an actual use case where this is a problem, I'll file a bug for that. This is almost too low level to be able to come up with a proper test case.