RESOLVED FIXED 106926
Web Inspector: inspectedWindow.eval("IamUndefined.prop", callback) fails to give exception text 
https://bugs.webkit.org/show_bug.cgi?id=106926
Summary Web Inspector: inspectedWindow.eval("IamUndefined.prop", callback) fails to g...
johnjbarton
Reported 2013-01-15 11:06:07 PST
When the inspectedWindow.eval() throws, the result is undefined instead of the text of the error messages. Patch ready.
Attachments
Patch (4.41 KB, patch)
2013-01-15 11:11 PST, johnjbarton 		no flags
DetailsFormatted DiffDiff
Patch (4.40 KB, patch)
2013-01-16 10:42 PST, johnjbarton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
johnjbarton
Comment 1 2013-01-15 11:11:46 PST
Created attachment 182810 [details] Patch
Build Bot
Comment 2 2013-01-15 12:53:50 PST
Comment on attachment 182810 [details] Patch Attachment 182810 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15873954 New failing tests: inspector/extensions/extensions-eval.html
Andrey Kosyakov
Comment 3 2013-01-16 03:43:14 PST
Comment on attachment 182810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182810&action=review > LayoutTests/inspector/extensions/extensions-eval-expected.txt:16 > +Evaluate: "ReferenceError: IamNotDefined is not defined" (exception: true) I think JSC may have other wording for the error -- so perhaps just eval('throw "exception"'), this would let us avoid custom test expectations.
Build Bot
Comment 4 2013-01-16 06:04:47 PST
Comment on attachment 182810 [details] Patch Attachment 182810 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15908409 New failing tests: inspector/extensions/extensions-eval.html
johnjbarton
Comment 5 2013-01-16 10:42:34 PST
Created attachment 183006 [details] Patch
Andrey Kosyakov
Comment 6 2013-01-17 03:34:46 PST
Comment on attachment 183006 [details] Patch LGTM
WebKit Review Bot
Comment 7 2013-01-18 02:23:27 PST
Comment on attachment 183006 [details] Patch Clearing flags on attachment: 183006 Committed r140114: <http://trac.webkit.org/changeset/140114>
WebKit Review Bot
Comment 8 2013-01-18 02:23:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.