Bug 106926 - Web Inspector: inspectedWindow.eval("IamUndefined.prop", callback) fails to give exception text
Summary: Web Inspector: inspectedWindow.eval("IamUndefined.prop", callback) fails to g...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 106811
  Show dependency tree / graph
 
Reported: 2013-01-15 11:06 PST by johnjbarton
Modified: 2013-01-18 02:23 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2013-01-15 11:11 PST, johnjbarton 		no flags Details | Formatted Diff | Diff
Patch (4.40 KB, patch)
2013-01-16 10:42 PST, johnjbarton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2013-01-15 11:06:07 PST 
When the inspectedWindow.eval() throws, the result is undefined instead of the text of the error messages.

Patch ready.
Comment 1 johnjbarton 2013-01-15 11:11:46 PST 
Created attachment 182810 [details]
Patch
Comment 2 Build Bot 2013-01-15 12:53:50 PST 
Comment on attachment 182810 [details]
Patch

Attachment 182810 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15873954

New failing tests:
inspector/extensions/extensions-eval.html
Comment 3 Andrey Kosyakov 2013-01-16 03:43:14 PST 
Comment on attachment 182810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182810&action=review

> LayoutTests/inspector/extensions/extensions-eval-expected.txt:16
> +Evaluate: "ReferenceError: IamNotDefined is not defined" (exception: true)

I think JSC may have other wording for the error -- so perhaps just eval('throw "exception"'), this would let us avoid custom test expectations.
Comment 4 Build Bot 2013-01-16 06:04:47 PST 
Comment on attachment 182810 [details]
Patch

Attachment 182810 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15908409

New failing tests:
inspector/extensions/extensions-eval.html
Comment 5 johnjbarton 2013-01-16 10:42:34 PST 
Created attachment 183006 [details]
Patch
Comment 6 Andrey Kosyakov 2013-01-17 03:34:46 PST 
Comment on attachment 183006 [details]
Patch

LGTM
Comment 7 WebKit Review Bot 2013-01-18 02:23:27 PST 
Comment on attachment 183006 [details]
Patch

Clearing flags on attachment: 183006

Committed r140114: <http://trac.webkit.org/changeset/140114>
Comment 8 WebKit Review Bot 2013-01-18 02:23:31 PST 
All reviewed patches have been landed.  Closing bug.