RESOLVED FIXED 106916
[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize() 
https://bugs.webkit.org/show_bug.cgi?id=106916
Summary [V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
Kentaro Hara
Reported 2013-01-15 09:34:33 PST
This is one of steps to remove optional Isolate parameters.
Attachments
Patch (6.49 KB, patch)
2013-01-15 09:36 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (7.16 KB, patch)
2013-01-16 00:17 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-15 09:36:43 PST
Created attachment 182792 [details] Patch
Adam Barth
Comment 2 2013-01-15 12:35:33 PST
Comment on attachment 182792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182792&action=review > Source/WebCore/bindings/v8/SerializedScriptValue.h:88 > + ScriptValue deserializeForInspector(ScriptState*); > + ScriptValue deserializeForInspector(ScriptState*, v8::Isolate*); We should put the Isolate into ScriptState instead of passing them separately. Everyone who takes a ScriptState is going to need an isolate.
Kentaro Hara
Comment 3 2013-01-16 00:17:29 PST
Created attachment 182925 [details] patch for landing
Kentaro Hara
Comment 4 2013-01-16 00:18:08 PST
(In reply to comment #2) > We should put the Isolate into ScriptState instead of passing them separately. Everyone who takes a ScriptState is going to need an isolate. Done. Thanks!
Kentaro Hara
Comment 5 2013-01-16 00:45:58 PST
We might want to implement v8::Context::GetIsolate(). At entry points from WebCore, we have a Frame or a ScriptExecutionContext, which can be converted to a v8::Context. So once v8::Context::GetIsolate() is exposed, we can get an Isolate without calling v8::Isolate::GetCurrent(). I'm implementing v8::Context::GetIsolate().
Kentaro Hara
Comment 6 2013-01-16 01:56:38 PST
(In reply to comment #5) > I'm implementing v8::Context::GetIsolate(). The V8 patch is here: https://chromiumcodereview.appspot.com/11968011/
WebKit Review Bot
Comment 7 2013-01-16 02:03:38 PST
Comment on attachment 182925 [details] patch for landing Clearing flags on attachment: 182925 Committed r139854: <http://trac.webkit.org/changeset/139854>
WebKit Review Bot
Comment 8 2013-01-16 02:03:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.