Bug 106912 - IndexedDB: Remove dependency on IDBKey type from IDLs
Summary: IndexedDB: Remove dependency on IDBKey type from IDLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks: 97375
  Show dependency tree / graph
 
Reported: 2013-01-15 09:03 PST by Joshua Bell
Modified: 2013-01-22 13:23 PST (History)
9 users (show)

See Also:

Attachments
Patch (50.18 KB, patch)
2013-01-15 09:13 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (50.14 KB, patch)
2013-01-16 16:42 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2013-01-15 09:03:53 PST 
IndexedDB: Remove dependency on IDBKey type from IDLs
Comment 1 Joshua Bell 2013-01-15 09:13:59 PST 
Created attachment 182788 [details]
Patch
Comment 2 Joshua Bell 2013-01-15 09:17:09 PST 
See http://wkbug.com/97375 for more context.

This is the preamble to removing special cases for IDBKey from WebKitIDL (code generators, custom binding code, etc).

On the one hand this gets us closer to having WebKitIDL match WebIDL - "IDBKey" is replaced by "any" in our IDL files. On the other, this is more code at many of the method implementations, violating DRY.
Comment 3 Joshua Bell 2013-01-15 09:17:31 PST 
dgrogan@, alecflett@ - can you guys take a preliminary look?
Comment 4 Joshua Bell 2013-01-16 16:42:40 PST 
Created attachment 183060 [details]
Patch
Comment 5 Joshua Bell 2013-01-16 16:42:59 PST 
New patch is just a rebase, and I wanted to get the bots to give it a try.
Comment 6 Alec Flett 2013-01-18 16:27:44 PST 
Comment on attachment 183060 [details]
Patch

lgtm
Comment 7 Joshua Bell 2013-01-18 16:28:44 PST 
haraken@ - can you take a look?
Comment 8 Kentaro Hara 2013-01-19 01:49:02 PST 
Comment on attachment 183060 [details]
Patch

LGTM
Comment 9 WebKit Review Bot 2013-01-22 13:23:04 PST 
Comment on attachment 183060 [details]
Patch

Clearing flags on attachment: 183060

Committed r140457: <http://trac.webkit.org/changeset/140457>
Comment 10 WebKit Review Bot 2013-01-22 13:23:08 PST 
All reviewed patches have been landed.  Closing bug.