Bug 106910 - Move parent pointer from TreeShared to subclass
Summary: Move parent pointer from TreeShared to subclass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 08:26 PST by Antti Koivisto
Modified: 2013-01-15 10:13 PST (History)
8 users (show)

See Also:

Attachments
patch (11.84 KB, patch)
2013-01-15 10:03 PST, Antti Koivisto 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-01-15 08:26:25 PST 
This simplifies TreeShared and makes code dealing with parents more understandable.
Comment 1 Antti Koivisto 2013-01-15 10:03:13 PST 
Created attachment 182798 [details]
patch
Comment 2 Darin Adler 2013-01-15 10:05:54 PST 
Comment on attachment 182798 [details]
patch

Looks fine. I still hope that some day we can retire the TreeShared class and find a different way to handle reference counting in the trees, and in a way this takes us one small step closer to that.
Comment 3 Antti Koivisto 2013-01-15 10:13:32 PST 
http://trac.webkit.org/changeset/139751