Bug 106907 - [chromium] add title text direction attribute to TestRunner
Summary: [chromium] add title text direction attribute to TestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 07:54 PST by jochen
Modified: 2013-01-16 01:44 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.75 KB, patch)
2013-01-15 07:55 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (8.82 KB, patch)
2013-01-15 13:02 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (8.80 KB, patch)
2013-01-16 00:30 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-15 07:54:46 PST 
[chromium] add title text direction attribute to TestRunner
Comment 1 jochen 2013-01-15 07:55:02 PST 
Created attachment 182775 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-15 07:58:27 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 jochen 2013-01-15 13:02:48 PST 
Created attachment 182834 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-01-15 13:36:24 PST 
Comment on attachment 182834 [details]
Patch for landing

Clearing flags on attachment: 182834

Committed r139779: <http://trac.webkit.org/changeset/139779>
Comment 5 WebKit Review Bot 2013-01-15 13:36:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Levi Weintraub 2013-01-15 14:49:18 PST 
Broke the build. Rolled out in http://trac.webkit.org/changeset/139795. It looks like WebTextDirection.h was left out of the checkin.
Comment 7 jochen 2013-01-16 00:28:20 PST 
(In reply to comment #6)
> Broke the build. Rolled out in http://trac.webkit.org/changeset/139795. It looks like WebTextDirection.h was left out of the checkin.

Thanks for rolling out.

Just for the record, the header is not missing, but TestRunner public API headers need to specify the full path to WebKit public API headers.
Comment 8 jochen 2013-01-16 00:30:46 PST 
Created attachment 182930 [details]
Patch
Comment 9 WebKit Review Bot 2013-01-16 01:43:58 PST 
Comment on attachment 182930 [details]
Patch

Clearing flags on attachment: 182930

Committed r139850: <http://trac.webkit.org/changeset/139850>
Comment 10 WebKit Review Bot 2013-01-16 01:44:02 PST 
All reviewed patches have been landed.  Closing bug.