Bug 106899 – [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform

[Mark Pilgrim (Google)]

Created attachment 182749 [details]
Patch

[WebKit Review Bot]

Attachment 182749 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:213:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:215:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 182749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182749&action=review

This looks good.  All these files have minor style issues, but I think you're right not to chase them.

> Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h:42
> +

Usually we skip these blank lines for forward declarations.

> Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h:46
> +

This one too

[WebKit Review Bot]

Comment on attachment 182749 [details]
Patch

Clearing flags on attachment: 182749

Committed r139774: <http://trac.webkit.org/changeset/139774>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.