Bug 106898 - [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
Summary: [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Florin Malita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 06:04 PST by Florin Malita
Modified: 2013-01-15 08:59 PST (History)
4 users (show)

See Also:


Attachments
Composited rounded rect shows opaque black corners. (172 bytes, text/html)
2013-01-15 06:04 PST, Florin Malita
no flags Details
Patch (11.72 KB, patch)
2013-01-15 08:19 PST, Florin Malita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2013-01-15 06:04:21 PST
Created attachment 182748 [details]
Composited rounded rect shows opaque black corners.

PlatformContextSkia::drawRRect (added http://trac.webkit.org/changeset/139191) should call didDrawBounded, not didDrawRect.
Comment 1 Florin Malita 2013-01-15 08:19:09 PST
Created attachment 182780 [details]
Patch
Comment 2 Stephen White 2013-01-15 08:20:38 PST
Comment on attachment 182780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182780&action=review

> LayoutTests/platform/chromium/TestExpectations:4219
> +# Needs platform-specific results

Is there a way to do this as a reftest?  Maybe the same thing, but without the translateZ, so it uses the software path?
Comment 3 Florin Malita 2013-01-15 08:22:48 PST
Comment on attachment 182780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182780&action=review

>> LayoutTests/platform/chromium/TestExpectations:4219
>> +# Needs platform-specific results
> 
> Is there a way to do this as a reftest?  Maybe the same thing, but without the translateZ, so it uses the software path?

I did try a reftest first, but unfortunately the compositor seems to affect the corners' anti-aliasing.
Comment 4 Stephen White 2013-01-15 08:23:48 PST
(In reply to comment #3)
> (From update of attachment 182780 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182780&action=review
> 
> >> LayoutTests/platform/chromium/TestExpectations:4219
> >> +# Needs platform-specific results
> > 
> > Is there a way to do this as a reftest?  Maybe the same thing, but without the translateZ, so it uses the software path?
> 
> I did try a reftest first, but unfortunately the compositor seems to affect the corners' anti-aliasing.

Ahh, of course.
Comment 5 Stephen White 2013-01-15 08:24:07 PST
Comment on attachment 182780 [details]
Patch

Looks good, bots willing.  r=me
Comment 6 Florin Malita 2013-01-15 08:40:17 PST
Comment on attachment 182780 [details]
Patch

Thanks, Stephen.
Comment 7 WebKit Review Bot 2013-01-15 08:59:21 PST
Comment on attachment 182780 [details]
Patch

Clearing flags on attachment: 182780

Committed r139745: <http://trac.webkit.org/changeset/139745>
Comment 8 WebKit Review Bot 2013-01-15 08:59:25 PST
All reviewed patches have been landed.  Closing bug.